summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Hiltjo Posthuma 2022-10-31 11:43:34 +0100
committerGravatar Hiltjo Posthuma 2022-10-31 11:46:10 +0100
commitbcbc1ef5c4cf4875a4d66e7dc0919da88a6096a5 (patch)
tree91c59c049a8bd4ad71079bc26566a97527d41170
parentfix leak when getline fails (diff)
readstdin: add a comment
Maybe too obvious / redundant, but OK.
-rw-r--r--dmenu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/dmenu.c b/dmenu.c
index e786d7a..8d96b6c 100644
--- a/dmenu.c
+++ b/dmenu.c
@@ -562,7 +562,7 @@ readstdin(void)
line[len - 1] = '\0';
items[i].text = line;
items[i].out = 0;
- line = NULL;
+ line = NULL; /* next call of getline() allocates a new line */
}
free(line);
if (items)
ss='logsubject'>Fix usage(), -m and -M for styles were absent.Gravatar Quentin Rameau 1-1/+1 Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-11-03Fix fullscreen handlingGravatar Quentin Rameau 2-7/+5 Handle the fullscreen in a more consistent way with other options: -f disables fullscreen while -F enables fullscreen. Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-31Add setstyle()Gravatar Quentin Rameau 1-14/+14 Regroup style uri setting application calls under one function. Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-31Fix style files handling: stop leaking strings.Gravatar Quentin Rameau 1-14/+22 Everytime getstyle() was being called, we returned newly allocated strings without ever freing them. Now uri stylefiles only get allocated once at setup(). Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-31Style changes in config.def.h.Gravatar Christoph Lohmann 1-65/+65 2015-10-20Continue style fixing: function declarations, code alignementGravatar Quentin Rameau 1-373/+444 Here are the changes we discussed on the mailing-list. Alignement is pushed to the first parameter of the function, which seems to be what people agrees on. Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-18style fixes: space after keywords, () with sizeofGravatar Markus Teich 1-103/+103 Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-18whitespace fixesGravatar Markus Teich 1-13/+13 Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-18fix style path generationGravatar Markus Teich 1-1/+1 Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-13Style cleanup.Gravatar Christoph Lohmann 1-2/+1 2015-10-13Fix the way system files are handled at surf startup.Gravatar Quentin Rameau 1-27/+56 1. Do not chmod existing directories. 2. Fix the handling of tilde expansion in paths, don't expand ~foo to $HOME/foo but to foo's home directory. 3. Separate the creation of files and directories. We don't have to worry anymore about pathnames having to end with a '/' to be correctly handled. Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-10-13Fix atom value parsing in SETPROPGravatar Quentin Rameau 1-1/+3 xprop(1) encloses the returned atom string value in double quotes while it doesn't when the value is unset. Original simple parsing would fail and parse the atom name instead of getting an empty value. Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-09-08Remove the pax intermediary.Gravatar Christoph Lohmann 1-1/+0 Compile webkit without jit and you don't need to disable mprotect. 2015-08-19Fixing the paxctl check.Gravatar Christoph Lohmann 1-1/+1 Thanks quinq for the tip. 2015-08-18Add PaX support.Gravatar Christoph Lohmann 1-0/+1 Mprotect needs to be turned off for Webkit. 2015-08-18Torified surf is unstableGravatar GhostAV 1-2/+6 On Tue, Aug 18, 2015 at 12:38:40PM +0200, Gabriel Pérez-Cerezo wrote: > It really seems to be a problem with torsocks. I have already solved > this problem with a patch GhostAV just sent me on this list that adds > SOCKS support to surf. It works fine now. As i failed to send the patch to the list, i resend it now: -- >8 -- From: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de> Subject: [PATCH] allow sock proxies Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-07-13Fix type of strictssl property.Gravatar Quentin Rameau 1-1/+1 Thanks to Mark Edgar <medgar123@gmail.com> for having spotted this. 2015-02-10Removing the debug print from the last commit.Gravatar Christoph Lohmann 1-1/+0 2015-02-10allow buttonrelease customization in config.hGravatar Markus Teich 2-8/+48 Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-02-03surf: see hover URL without changing titleGravatar Greg Reagle 1-0/+10 On Tue, Jan 27, 2015, at 11:52 AM, Christoph Lohmann wrote: > Then hook to the window leaving event in GTK or X11 and set the title to > your needs. I will welcome a patch. Patch is attached. I am a total novice in GTK programming, so I don't know what type the callback function is supposed to be (hence the void pointers) or whether I registered it properly. But it does work well for me. -- http://www.fastmail.com - Access your email from home and the web From a33f06da092bf920b6a286ea7688b32944d79a50 Mon Sep 17 00:00:00 2001 From: Greg Reagle <greg.reagle@umbc.edu> Date: Tue, 27 Jan 2015 13:22:15 -0500 Subject: [PATCH] ensure that window title is web page title (not hover link) when leaving window Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-02-03Some cleanup in style.Gravatar Christoph Lohmann 1-2/+2 2015-01-26Describe the web page indicators too.Gravatar Christoph Lohmann 1-0/+1 2015-01-26It wasn't really clear what was meant with site indicators in the manpage.Gravatar Christoph Lohmann 1-0/+1 2015-01-26surf: documented indicators in man pageGravatar Greg Reagle 1-0/+50 Patch attached. -- http://www.fastmail.com - The professional email service From 4a64624fee94c16c093d2b192389bad9bd6675d8 Mon Sep 17 00:00:00 2001 From: Greg Reagle <greg.reagle@umbc.edu> Date: Mon, 26 Jan 2015 14:29:05 -0500 Subject: [PATCH] Documented indicators Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-01-20fix stylesheet interna.Gravatar Markus Teich 1-19/+12 * no more segfault when running `surf -m` * allow to enable custom styles after `surf -m` with mod+shift+m * use enablestyles instead of the webkit-setting, which clears things up a bit Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-01-20Only plumb some URI, when it's ASCII.Gravatar Christoph Lohmann 1-1/+10 2015-01-20Oh my blob!Gravatar Christoph Lohmann 1-0/+1 Adding blob: to the URIS handled by the browser. 2015-01-19Data: is part of the browser too.Gravatar Christoph Lohmann 1-0/+1 2015-01-19file:// should be handled in surf too.Gravatar Christoph Lohmann 1-0/+1 2015-01-19Remove the debugging from the testing.Gravatar Christoph Lohmann 1-1/+0 2015-01-19Add some description for the plumb feature.Gravatar Christoph Lohmann 1-0/+3 2015-01-19Add plumbing functionality.Gravatar Christoph Lohmann 2-2/+28 2015-01-18Add a comment about how the styles are iterated.Gravatar Christoph Lohmann 1-0/+4 Thanks quing for noticing. 2015-01-18My CMD was too short. :OGravatar Christoph Lohmann 1-1/+1 Thanks Carlos Torres for mentioning this. 2015-01-17Add the manpage changes for the disk cache support.Gravatar Christoph Lohmann 1-1/+7 2015-01-17Adding disk cache support for soup.Gravatar Christoph Lohmann 2-9/+40 This is a merge of the patch of Ben Woolley <tautolog@gmail.com> 2015-01-17Fix extra newline, and add -g where other switches are forwarded.Gravatar Ben Woolley 1-1/+3 Signed-off-by: Christoph Lohmann <20h@r-36.net> 2015-01-17Newer libc want _DEFAULT_SOURCE.Gravatar Christoph Lohmann 1-1/+1 2015-01-17Major styles update.Gravatar Christoph Lohmann 3-11/+84 In config.h there is now some styles array to apply site-specific styles. This can be toggled using the -mM flags. If a stylefile is manually specified, then this will overwrite everything. 2015-01-02Fix a typo in surf manual.Gravatar Jakukyo Friel 1-1/+1 `Ctrl-/` displays incorrectly in `man surf` on my machine. A patch is attached. (You also access it here: https://github.com/weakish/surf/commit/07e97eccedd96eabf14b2fbf77de75ec1b594d97) ---- surf.1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Christoph Lohmann <20h@r-36.net> 2014-09-28Minor style change.Gravatar Christoph Lohmann 1-1/+1 2014-09-28Make »Copy image address« work.Gravatar Christoph Lohmann 1-3/+10 Thanks yui@blekksprut.net for the patch! 2014-08-07Mention xdotool in SEE ALSO too.Gravatar Christoph Lohmann 1-1/+2 2014-08-07Fix the manpage about xid.Gravatar Christoph Lohmann 1-1/+3 Something was missing from this one sentence. Now it is complete.